docs(demos): add a variety of button demos #5628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
For the user-facing demo, the fabs should have icons inside rather than text |
jelbourn
reviewed
Jul 10, 2017
| <div class="button-row"> | ||
| <button md-button>Basic</button> | ||
| <button md-button color="primary">Primary</button> | ||
| <button md-button color="accent">Ascent</button> |
There was a problem hiding this comment.
"Ascent" -> "Accent" (throughout file)
| <button md-icon-button color="primary"><md-icon class="md-24">favorite</md-icon></button> | ||
| <button md-icon-button color="accent"><md-icon class="md-24">favorite</md-icon></button> | ||
| <button md-icon-button color="warn"><md-icon class="md-24">favorite</md-icon></button> | ||
| <button md-icon-button disabled><md-icon class="md-24">favorite</md-icon></button> |
There was a problem hiding this comment.
Each icon button needs an aria-label
|
@jelbourn - ready for further review. |
jelbourn
reviewed
Jul 10, 2017
| <h3>Icon Buttons</h3> | ||
| <div class="button-row"> | ||
| <button md-icon-button><md-icon class="md-24" aria-label="favorite">favorite</md-icon></button> | ||
| <button md-icon-button color="primary"><md-icon class="md-24" aria-label="favorite">favorite</md-icon></button> |
There was a problem hiding this comment.
Should be a bit more specific w/ the aria-label:
"Example icon-button with a heart icon"
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a variety of new button demos and combinations.